Github user djoelz commented on the pull request:
https://github.com/apache/incubator-zeppelin/pull/53#issuecomment-132313144
I feel that this needs far more test coverage with all the new public
methods it introduces. Just changing the existing tests is not enough. Please
add unit tests to the methods added/changed in NotebookRestApi
SecurityRestApi
ZeppelinServer
NotebookServer
TicketContainer
Notebook
VFSNotebookRepo
Also we should think about adding security with interfaces and have this be
an implementation of those interfaces. Thoughts?
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at [email protected] or file a JIRA ticket
with INFRA.
---
