Github user eranwitkon commented on the pull request:
https://github.com/apache/incubator-zeppelin/pull/164#issuecomment-128366820
I agree that in the long run this could be a better solution but I believe
that making small steps here is important and solve current problems.
For my users using this change is valuable by itself.
I am willing to see if I can do the next step as well once we have this one
completed.
Eran
On Thu, Aug 6, 2015 at 4:16 PM elbamos <[email protected]> wrote:
> Perhaps it makes sense to start moving to the point where interpret
> returns a collection of InterpreterResults rather than just one? Or that
we
> allow one type of InterpreterResult to contain multiple nested
> InterpreterResults?
>
> > On Aug 6, 2015, at 4:45 AM, Eran <[email protected]> wrote:
> >
> > I changed the implementation according to the new rule:
> > "paragraph type will be set by the first magic word in the paragraph"
> this allows for test such as the following to be parsed as before
> >
> > println(s"some text before magic word %table col1\tcol2\naaa\t%html
> <h3>123</h3>\n")
> >
> >
> > also support omitting text before magic word so magic can be used in
> spark code
> >
> > val somerdd = sc.parallelize(1 to 10)
> > println("%table key\tvalue\nrdd count \t%html <h3>" + somerdd.count
> +"</h3>\n")
> >
> >
> > one thing to note is that it is up to the first magic word to handle the
> proceeding text. e.g. %table knows how to pars %html within it. but %table
> followed by %table will be handled differently.
> >
> > println("%table col A\tcol B\naaa\t123\n")
> > println("%table col Z\naaa\n123\n")
> >
> >
> > if no more changes, this is ready for merge
> > Eran
> >
> > â
> > Reply to this email directly or view it on GitHub.
> >
>
> â
> Reply to this email directly or view it on GitHub
>
<https://github.com/apache/incubator-zeppelin/pull/164#issuecomment-128359193>
> .
>
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at [email protected] or file a JIRA ticket
with INFRA.
---
