Jeho Lee created ZEPPELIN-6060:
----------------------------------
Summary: Enhance Thrift build by generating thrift java files with
shell script in maven
Key: ZEPPELIN-6060
URL: https://issues.apache.org/jira/browse/ZEPPELIN-6060
Project: Zeppelin
Issue Type: Improvement
Components: zeppelin-interpreter
Reporter: Jeho Lee
Assignee: Jeho Lee
The Thrift files in Zeppelin-Interpreter are currently managed manually using a
shell script, with the generated Java files uploaded to GitHub. While this
ensures consistent use of the same Thrift version across environments, it also
increases the risk of human error during the build process.
For example, if a contributor forgets to run the shell script after modifying a
Thrift file, or uses the wrong Thrift version, it can lead to build failures or
inconsistencies in the generated Java files.
To resolve these issues, I think it might be a good idea to integrate the shell
script into the Maven build process. This would automate the generation of
Thrift Java files, reducing the risk of manual errors and improving build
consistency. With Maven integration, Java files would be automatically
generated whenever Thrift files are modified, ensuring contributors work with
the correct versions.
Additionally, I think adding thrift version management and installation
features to the shell script (genthrift.sh) would help ensure all contributors
use the same Thrift version, maintaining a consistent development environment.
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
