jongyoul commented on code in PR #4503:
URL: https://github.com/apache/zeppelin/pull/4503#discussion_r1014779148


##########
zeppelin-integration/pom.xml:
##########
@@ -37,14 +37,9 @@
   </prerequisites>
 
   <properties>
-    <project.build.sourceEncoding>UTF-8</project.build.sourceEncoding>

Review Comment:
   I read 
https://maven.apache.org/plugins/maven-resources-plugin/examples/encoding.html 
and found we are using system-dependent encoding. Is it ok? Otherwise, is it 
better to set UTF-8 in a root pom? WDYT?



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]

Reply via email to