huage1994 commented on PR #4462: URL: https://github.com/apache/zeppelin/pull/4462#issuecomment-1246176952
> So if I understand the unit tests correctly, the following asserts only test the properties and not the successful connection. Correct? > > https://github.com/apache/zeppelin/blob/bbe46d737d6738c0a6cc2b58de90bbb16c6b3c55/jdbc/src/test/java/org/apache/zeppelin/jdbc/JDBCInterpreterTest.java#L571-L573 Yes. The asserts and this test case run well without any error. It is the following line of code to try to connect h2, and print error-level log about `JdbcSQLInvalidAuthorizationSpecException`. Actually It does not affect the running of the entire test case. This PR is only to remove the confusing and useless error-level log about `JdbcSQLInvalidAuthorizationSpecException` . https://github.com/apache/zeppelin/blob/23f3acf2086d78630dbc3d18016cb7e40c390ef2/jdbc/src/test/java/org/apache/zeppelin/jdbc/JDBCInterpreterTest.java#L579 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: dev-unsubscr...@zeppelin.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
