[GitHub] [zeppelin] JoWonHyeung commented on a diff in pull request #4419: [ZEPPELIN-5773] Fix isWindowsPath Function in ZeppelinConfiguration class

[GitBox]

JoWonHyeung commented on code in PR #4419:
URL: https://github.com/apache/zeppelin/pull/4419#discussion_r927675104


##########
zeppelin-zengine/src/test/java/org/apache/zeppelin/conf/ZeppelinConfigurationTest.java:
##########
@@ -69,18 +69,18 @@ public void getAllowedOriginsNoneTest() throws 
MalformedURLException {
   }
 
   @Test
-  public void isWindowsPathTestTrue() {
+  public void checkWindowsTestTrue() {
 
     ZeppelinConfiguration conf = 
ZeppelinConfiguration.create("zeppelin-test-site.xml");
-    Boolean isIt = conf.isWindowsPath("c:\\test\\file.txt");
+    Boolean isIt = conf.checkWindows();
     Assert.assertTrue(isIt);
   }
 
   @Test
-  public void isWindowsPathTestFalse() {
+  public void checkWindowsTestFalse() {
 
     ZeppelinConfiguration conf = 
ZeppelinConfiguration.create("zeppelin-test-site.xml");
-    Boolean isIt = conf.isWindowsPath("~/test/file.xml");
+    Boolean isIt = conf.checkWindows();
     Assert.assertFalse(isIt);
   }

Review Comment:
   I will question it.
   
   I only changed the function name in the previous version for the time being. 
The internal code is the same as before.
   
   _SystemUtils.IS_OS_WINDOWS_ will have different results for each operating 
system, so how can I create test code?
   
   Do you have any good ideas?
   
   Thank you.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: dev-unsubscr...@zeppelin.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org