saLeox commented on code in PR #4374:
URL: https://github.com/apache/zeppelin/pull/4374#discussion_r884708245
##########
zeppelin-zengine/src/main/java/org/apache/zeppelin/notebook/NoteManager.java:
##########
@@ -181,7 +182,9 @@ public void saveNote(Note note, AuthenticationInfo subject)
throws IOException {
} else {
addOrUpdateNoteNode(new NoteInfo(note));
noteCache.putNote(note);
- this.notebookRepo.save(note, subject);
+ synchronized (this) {
Review Comment:
Sorry, there is an update for the reason makes it `synchronized`, it is
because the `note` object will not be persisted successfully in the concurrent
situation, and result in a NPE error in the `notebookRepo.get()` function.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscr...@zeppelin.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
