huage1994 commented on code in PR #4360:
URL: https://github.com/apache/zeppelin/pull/4360#discussion_r857061596


##########
jdbc/src/main/java/org/apache/zeppelin/jdbc/JDBCInterpreter.java:
##########
@@ -604,6 +604,10 @@ private String appendProxyUserToURL(String url, String 
user, String propertyKey)
 
   // only add tags for hive jdbc
   private String appendTagsToURL(String url, InterpreterContext context) {
+    if 
(!Boolean.parseBoolean(getProperty("zeppelin.jdbc.hive.engines.tag.enable"))) {

Review Comment:
   > set default value as `true` in case 
`zeppelin.jdbc.hive.engines.tag.enable` is not set when user upgrade zeppelin 
from old versions
   
   Good point! 
    



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: dev-unsubscr...@zeppelin.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org

Reply via email to