[GitHub] [zeppelin] zjffdu commented on a diff in pull request #4362: [ZEPPELIN-5728] Absence of cancelNote method in Zeppelin Client Api

[GitBox]

zjffdu commented on code in PR #4362:
URL: https://github.com/apache/zeppelin/pull/4362#discussion_r852615303


##########
zeppelin-client-examples/src/main/java/org/apache/zeppelin/client/examples/ZeppelinClientExample.java:
##########
@@ -56,6 +56,8 @@ public static void main(String[] args) throws Exception {
               "%python\nimport time\ntime.sleep(5)\nprint('done')");
       zClient.submitParagraph(noteId, paragraphId2);
       zClient.waitUtilParagraphRunning(noteId, paragraphId2);
+      // It's also ok here to call zClient.cancelNote(noteId);

Review Comment:
   Need to add another test case for `cancelNote` instead of just leaving a 
comment



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: dev-unsubscr...@zeppelin.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org