jasmine-song opened a new pull request, #4361:
URL: https://github.com/apache/zeppelin/pull/4361

   ### What is this PR for?
   
   When use the SQL statement in paragraph, some keywords are not highlighted
   The reason is new web ui code bug(zeppeline-web-angular), front-end send the 
parameter is 'magic', but back-end 
   receive the parameter is  paragraphText, or else catch,  don't return 
editsetting
   This PR modify the correct parameter
   
   ### What type of PR is it?
   Bug Fix
   
   ### Todos
   * [ ] - Task
   
   ### What is the Jira issue?
   * Open an issue on Jira https://issues.apache.org/jira/browse/ZEPPELIN-5682
   
   ### How should this be tested?
   * CI passed
   
   ### Screenshots (if appropriate)
    
   
![image](https://user-images.githubusercontent.com/44150070/163777618-98ec3566-a2c0-40b8-8d66-45785bc738e8.png)
   the back-end code is
   `  public void getEditorSetting(String noteId,
                                  String paragraphText,
                                  ServiceContext context,
                                  ServiceCallback<Map<String, Object>> 
callback) throws IOException {
       notebook.processNote(noteId,
         note -> {
           if (note == null) {
             callback.onFailure(new NoteNotFoundException(noteId), context);
           }
           try {
             Map<String, Object> settings = 
notebook.getInterpreterSettingManager().
                 getEditorSetting(paragraphText, noteId);
             callback.onSuccess(settings, context);
           } catch (Exception e) {
             callback.onFailure(new IOException("Fail to getEditorSetting", e), 
context);
           }
           return null;
         });
     }`
   
   ### Questions:
   * Does the licenses files need to update?  no
   * Is there breaking changes for older versions? no
   * Does this needs documentation? no
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: dev-unsubscr...@zeppelin.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org

Reply via email to