zjffdu commented on a change in pull request #4288:
URL: https://github.com/apache/zeppelin/pull/4288#discussion_r816549086



##########
File path: 
zeppelin-zengine/src/main/java/org/apache/zeppelin/notebook/NoteManager.java
##########
@@ -78,8 +78,8 @@ private void init() throws IOException {
         {
           try {
             addOrUpdateNoteNode(new Note(new NoteInfo(entry.getKey(), 
entry.getValue())));
-          } catch (IOException e) {
-            LOGGER.warn(e.getMessage());
+          } catch (Throwable e) {
+            LOGGER.warn("addOrUpdateNoteNode Fail: {}", entry.getKey() + " - " 
+ e.getMessage(), e);

Review comment:
       I see, could you add one comment to explain that the invalid file name 
would cause exception here?




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: dev-unsubscr...@zeppelin.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


Reply via email to