huage1994 commented on a change in pull request #4293:
URL: https://github.com/apache/zeppelin/pull/4293#discussion_r795164516
##########
File path:
zeppelin-plugins/launcher/yarn/src/main/java/org/apache/zeppelin/interpreter/launcher/YarnRemoteInterpreterProcess.java
##########
@@ -178,6 +178,10 @@ public void start(String userName) throws IOException {
this.appId = appResponse.getApplicationId();
ApplicationSubmissionContext appContext =
yarnApplication.getApplicationSubmissionContext();
appContext = createApplicationSubmissionContext(appContext);
+ String YARN_NODE_LABEL_EXPRESSION =
"zeppelin.interpreter.yarn.node.label.expression";
+ if(properties.containsKey(YARN_NODE_LABEL_EXPRESSION) &&
StringUtils.isNotEmpty(properties.getProperty(YARN_NODE_LABEL_EXPRESSION))) {
Review comment:
> You can use `properties.getProperty(key, defaultValue)` to simplify it
Yes, it's a good idea
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscr...@zeppelin.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
