[GitHub] [zeppelin] huage1994 commented on a change in pull request #4289: [ZEPPELIN-5629] spark.driver.extraJavaOptions setting in %spark.conf does not work well

[GitBox]

huage1994 commented on a change in pull request #4289:
URL: https://github.com/apache/zeppelin/pull/4289#discussion_r787395820



##########
File path: 
zeppelin-zengine/src/main/java/org/apache/zeppelin/interpreter/launcher/SparkInterpreterLauncher.java
##########
@@ -77,6 +72,10 @@ public SparkInterpreterLauncher(ZeppelinConfiguration zConf, 
RecoveryStorage rec
         env.put(key, propValue);
       }
       if (isSparkConf(key, propValue)) {
+        if (Objects.equals("spark.driver.extraJavaOptions", key)) {

Review comment:
       > It's better to add a comment explaining why handle 
`spark.driver.extraJavaOptions` in a specific way?
   
   thanks a lot for review  @zjffdu,  it's done.
   
   




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: dev-unsubscr...@zeppelin.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org