xiejiajun opened a new pull request #4264:
URL: https://github.com/apache/zeppelin/pull/4264


   ### What is this PR for?
   - The 
org.eclipse.jetty.websocket.common.WebSocketRemoteEndpoint#blockingWrite method 
has been to ensure that the websocket sends messages serially by 
`ReentrantLock` and `WriteBlocket`, so the NotebookSocket.send method does not 
need to be locked.
   - If we lock the NotebookSocket.send method, the NotebookServer#onClose 
method will be triggered when the NotebookSocket.send method sends a message 
abnormally. At this time, if there are other threads that need to send messages 
through the current Websocket Session to preempt the noteSocketMap lock in the 
ConnectionManager,  It will trigger a deadlock.
   
   ### What type of PR is it?
   [Bug Fix]
   
   ### Todos
   * [ ] - Task
   
   ### What is the Jira issue?
   * [ZEPPELIN-5572](https://issues.apache.org/jira/browse/ZEPPELIN-5572)
   
   ### How should this be tested?
   * CI
   
   ### Questions:
   * Does the licenses files need update? No
   * Is there breaking changes for older versions? No
   * Does this needs documentation? No
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: dev-unsubscr...@zeppelin.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


Reply via email to