Reamer commented on a change in pull request #4210:
URL: https://github.com/apache/zeppelin/pull/4210#discussion_r705464590
##########
File path:
zeppelin-server/src/main/java/org/apache/zeppelin/socket/NotebookServer.java
##########
@@ -16,10 +16,9 @@
*/
package org.apache.zeppelin.socket;
-import com.google.common.base.Strings;
-import com.google.gson.Gson;
-import com.google.gson.GsonBuilder;
-import com.google.gson.reflect.TypeToken;
+import shaded.com.google.gson.Gson;
+import shaded.com.google.gson.GsonBuilder;
+import shaded.com.google.gson.reflect.TypeToken;
Review comment:
We need to use the shaded GSON class at this point because
`Input.TypeAdapterFactory` is part of the Zeppelin interpreter.
`Input.TypeAdapterFactory` uses the shaded GSON from the Zeppelin server's
point of view.
Without this change you get the following compilation warning.
```
[ERROR]
/home/pdallig/git/zeppelin/zeppelin-server/src/main/java/org/apache/zeppelin/socket/NotebookServer.java:[139,40]
incompatible types: org.apache.zeppelin.display.RuntimeTypeAdapterFactory
cannot be converted to com.google.gson.TypeAdapterFactory
[ERROR]
/home/pdallig/git/zeppelin/zeppelin-server/src/main/java/org/apache/zeppelin/socket/ConnectionManager.java:[64,40]
incompatible types: org.apache.zeppelin.display.RuntimeTypeAdapterFactory
cannot be converted to com.google.gson.TypeAdapterFactory
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscr...@zeppelin.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
