[GitHub] [zeppelin] zjffdu commented on a change in pull request #4166: [ZEPPELIN-5439] Improve the logic of extract hive job url in JdbcInterpreter

[GitBox]

zjffdu commented on a change in pull request #4166:
URL: https://github.com/apache/zeppelin/pull/4166#discussion_r671641058



##########
File path: jdbc/src/main/java/org/apache/zeppelin/jdbc/JDBCInterpreter.java
##########
@@ -596,6 +598,24 @@ private String appendProxyUserToURL(String url, String 
user, String propertyKey)
     return connectionUrl.toString();
   }
 
+  // only add tags for hive jdbc
+  private String appendTagsToURL(String url, InterpreterContext context) {
+    StringBuilder builder = new StringBuilder(url);
+    if (url.startsWith("jdbc:hive2:")) {
+      Integer lastIndexOfQMark = builder.indexOf("?");
+      if (lastIndexOfQMark == -1) {
+        builder.append("?");

Review comment:
       Not sure what you mean. User may specify '?' in `default.url`




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: dev-unsubscr...@zeppelin.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org