zjffdu commented on a change in pull request #4162:
URL: https://github.com/apache/zeppelin/pull/4162#discussion_r669736329
##########
File path:
zeppelin-interpreter/src/main/java/org/apache/zeppelin/interpreter/lifecycle/TimeoutLifecycleManager.java
##########
@@ -53,7 +57,8 @@ public TimeoutLifecycleManager(ZeppelinConfiguration zConf,
ScheduledExecutorService checkScheduler = ExecutorFactory.singleton()
.createOrGetScheduled("TimeoutLifecycleManager", 1);
checkScheduler.scheduleAtFixedRate(() -> {
- if ((System.currentTimeMillis() - lastBusyTimeInMillis) >
timeoutThreshold) {
+ if ((System.currentTimeMillis() - lastBusyTimeInMillis) >
timeoutThreshold &&
+ noJobsRunning()) {
Review comment:
In one corner case, `lastBusyTimeInMilli` won't be updated, that is when
zeppelin server is dead then `RemoteInterpreterServer#getProgress` and
`RemoteInterpreterServer#getStatus` won't be called. Thanks for the comment,
let me update this PR with more comment to explain that.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscr...@zeppelin.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
