cuspymd commented on a change in pull request #4102:
URL: https://github.com/apache/zeppelin/pull/4102#discussion_r621830856



##########
File path: bin/zeppelin.sh
##########
@@ -68,6 +68,9 @@ do
     -h)
         usage
         ;;
+    *)
+        usage
+        ;;

Review comment:
       It would be nice if the following items could be modified as well. What 
do you think?
   - Combine `--help` and `-h` processing into one
   - Separate the `exit` call part from the `usage` function.
   - `*)` In the processing, call the `usage` function after `echo "Unsupported 
argument."`




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


Reply via email to