zjffdu commented on a change in pull request #4061:
URL: https://github.com/apache/zeppelin/pull/4061#discussion_r583434365



##########
File path: 
zeppelin-client-examples/src/main/java/org/apache/zeppelin/client/examples/ZeppelinClientExample.java
##########
@@ -41,6 +42,13 @@ public static void main(String[] args) throws Exception {
       noteId = zClient.createNote(notePath);
       System.out.println("Created note: " + noteId);
 
+      String newNotePath = notePath + "_rename";
+      zClient.renameNote(noteId, newNotePath);
+
+      NoteResult renamedNoteResult = zClient.queryNoteResult(noteId);
+      Assert.assertEquals(newNotePath, renamedNoteResult.getNotePath());

Review comment:
       Sorry, my fault, `ZeppelinClientExample` is not unit test class, it is 
only for demo. So no need assert here.
   You should add unit test in `ZeppelinClientIntegrationTest`




----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


Reply via email to