conker84 commented on pull request #3851: URL: https://github.com/apache/zeppelin/pull/3851#issuecomment-665506367
> > > @conker84 > > > Please remove the `zeppelin-web/package-lock.json` out of this PR. This changes aren't related to this PR. > > > > > > I guess that there is something broken in the build process of zeppelin-web, and definitely it should be `gitignored`... > > According to [npm help package-lock.json](https://github.com/npm/cli/blob/latest/docs/content/configuring-npm/package-lock-json.md#package-lockjson5) is intended to be checked into source control. Yes I know but in my experience, I think that it's better to have it ignored as then it generates a lot of these situations where the user just builds the project and generate the file with the same content but shuffled. ---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
