alexott commented on a change in pull request #3769: URL: https://github.com/apache/zeppelin/pull/3769#discussion_r426280440
########## File path: Dockerfile ########## @@ -0,0 +1,31 @@ +# +# Licensed to the Apache Software Foundation (ASF) under one or more +# contributor license agreements. See the NOTICE file distributed with +# this work for additional information regarding copyright ownership. +# The ASF licenses this file to You under the Apache License, Version 2.0 +# (the "License"); you may not use this file except in compliance with +# the License. You may obtain a copy of the License at +# +# http://www.apache.org/licenses/LICENSE-2.0 +# +# Unless required by applicable law or agreed to in writing, software +# distributed under the License is distributed on an "AS IS" BASIS, +# WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. +# See the License for the specific language governing permissions and +# limitations under the License. +# +FROM maven:3.5-jdk-8 as builder +ADD . /workspace/zeppelin +WORKDIR /workspace/zeppelin +# Allow npm and bower to run with root privileges +RUN echo "unsafe-perm=true" > ~/.npmrc && \ + echo '{ "allow_root": true }' > ~/.bowerrc && \ + mvn -B package -DskipTests -Pbuild-distr -Pspark-3.0 -Phadoop3 -Pspark-scala-2.12 -Pweb-angular && \ + # Example with doesn't compile all interpreters + # mvn -B package -DskipTests -Pweb-angular -Pscala-2.11 -Pbuild-distr -pl '!groovy,!submarine,!livy,!hbase,!pig,!file,!flink,!ignite,!kylin,!lens' && \ + # Removing stuff saves time, because docker creates a temporary layer + rm -rf ~/.m2 && \ + find . -maxdepth 1 -type d ! -iname zeppelin-distribution -exec rm -rf {} \; + +FROM ubuntu:18.04 +COPY --from=builder /workspace/zeppelin/zeppelin-distribution/target/zeppelin-0.9.0-SNAPSHOT/zeppelin-0.9.0-SNAPSHOT /opt/zeppelin Review comment: I maybe would try to make it version-independent? Or pass version explicitly, or infer somehow? ########## File path: k8s/zeppelin-server.yaml ########## @@ -115,7 +115,7 @@ spec: path: nginx.conf containers: - name: zeppelin-server - image: apache/zeppelin:0.9.0-SNAPSHOT + image: apache/zeppelin-server:0.9.0-SNAPSHOT Review comment: How it all will work on non-K8S? Like, using Docker just for not installing anything to machine, and one image is more handy to work with ---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
