[GitHub] [zeppelin] alexott commented on a change in pull request #3764: [ZEPPELIN-4797]. Enable multiple sql in jdbc interpreter by default

[GitBox]

alexott commented on a change in pull request #3764:
URL: https://github.com/apache/zeppelin/pull/3764#discussion_r420597759



##########
File path: jdbc/src/main/java/org/apache/zeppelin/jdbc/JDBCInterpreter.java
##########
@@ -695,17 +688,7 @@ private InterpreterResult executeSql(String propertyKey, 
String sql,
     }
 
     try {
-      List<String> sqlArray;
-      sql = sql.trim();
-      if (splitQuery) {
-        sqlArray = sqlSplitter.splitSql(sql);
-      } else {
-        if (sql.endsWith(";")) {
-          sql = sql.substring(0, sql.length() - 1);
-        }
-        sqlArray = Arrays.asList(sql);
-      }
-
+      List<String> sqlArray = sqlSplitter.splitSql(sql);
       for (int i = 0; i < sqlArray.size(); i++) {
         String sqlToExecute = sqlArray.get(i);

Review comment:
       for-each loop would look nicer :-)




----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org