Reamer commented on issue #3745:
URL: https://github.com/apache/zeppelin/pull/3745#issuecomment-617830785


   great pull request!
   
   Only one small question. Why setting a global JVM system property to disable 
the quartz update check?
   
   I think the following code is better, because:
    1) The compiler checks, if the property is still available.
    1) You have no side-effects, which other threads/tasks
   ```
       Properties schedulerProperties = new Properties();
       
schedulerProperties.setProperty(StdSchedulerFactory.PROP_SCHED_SKIP_UPDATE_CHECK,
 "true");
       return new StdSchedulerFactory(schedulerProperties).getScheduler();
   ```
   


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


Reply via email to