alexott commented on a change in pull request #3641: [ZEPPELIN-3751].
Interpreter Binding menu of note only shows default interpreter
URL: https://github.com/apache/zeppelin/pull/3641#discussion_r378177138
##########
File path: zeppelin-web/src/app/notebook/notebook.controller.js
##########
@@ -1251,11 +1251,11 @@ function NotebookCtrl($scope, $route, $routeParams,
$location, $rootScope,
};
const isSettingDirty = function() {
- // if (angular.equals($scope.interpreterBindings,
$scope.interpreterBindingsOrig)) {
- // return false;
- // } else {
- return false;
- // }
+ if (angular.equals($scope.interpreterBindings,
$scope.interpreterBindingsOrig)) {
+ return false;
+ } else {
+ return false;
Review comment:
do we need condition if we just return false in both cases?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
With regards,
Apache Git Services
