alexott commented on a change in pull request #3446: ZEPPELIN-4329 fix building
Scio with Scala 2.11
URL: https://github.com/apache/zeppelin/pull/3446#discussion_r325018220
##########
File path: pom.xml
##########
@@ -95,8 +95,10 @@
<properties>
<!-- language versions -->
<java.version>1.8</java.version>
- <scala.version>2.10.5</scala.version>
+ <scala.2.10.version>2.10.5</scala.2.10.version>
Review comment:
Yes, because the scio/beam dependencies are mess :-(
While Scio has both 2.10 & 2.11 dependencies, the Beam has either 2.10 or
2.11 dependencies, so it would require to switch Beam dependencies to higher
versions when compiling with 2.11.
So I decided to fix the issue this way - just to fix compilation problems,
etc., and then try to think how to make it more generic when working on JIRA
about removing Scala 2.10 & adding Scala 2.12, etc. But that could be still a
problem with Beam as it looks like that they aren't doing the releases that
depend on different Scala versions.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
With regards,
Apache Git Services
