zjffdu commented on a change in pull request #3411: ZEPPELIN-4272: Zeppelin
fails to compile when hadoop3 is enabled
URL: https://github.com/apache/zeppelin/pull/3411#discussion_r314147191
##########
File path:
zeppelin-zengine/src/main/java/org/apache/zeppelin/notebook/FileSystemStorage.java
##########
@@ -60,16 +62,39 @@
public FileSystemStorage(ZeppelinConfiguration zConf, String path) throws
IOException {
this.zConf = zConf;
this.hadoopConf = new Configuration();
+ URI zepConfigURI;
+ URI defaultFSURI;
+
+ zepConfigURI = getURI(path, "Failed to get URI path");
Review comment:
It is not a good practice to pass error message to function. And is `getURI`
necessary ? I see it only create new URI but do nothing else.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
With regards,
Apache Git Services
