bhavikpatel9977 commented on a change in pull request #3411: ZEPPELIN-4272:
Zeppelin fails to compile when hadoop3 is enabled
URL: https://github.com/apache/zeppelin/pull/3411#discussion_r309548716
##########
File path:
zeppelin-zengine/src/main/java/org/apache/zeppelin/notebook/FileSystemStorage.java
##########
@@ -60,16 +59,25 @@
public FileSystemStorage(ZeppelinConfiguration zConf, String path) throws
IOException {
this.zConf = zConf;
this.hadoopConf = new Configuration();
+ URI zepConfigURI;
+
+ zepConfigURI = getURI(path, "Failed to get URI path");
// disable checksum for local file system. because interpreter.json may be
updated by
// non-hadoop filesystem api
// disable caching for file:// scheme to avoid getting LocalFS which does
CRC checks
+
this.hadoopConf.setBoolean("fs.file.impl.disable.cache", true);
- this.hadoopConf.set("fs.file.impl", RawLocalFileSystem.class.getName());
Review comment:
Rather then adding new extra property we can also do something like this
```
if (!isS3AFileSystem(defaultFSURI, zepConfigURI)) {
this.hadoopConf.set("fs.file.impl", RawLocalFileSystem.class.getName());
}
public boolean isS3AFileSystem(URI defaultFSURI, URI zepConfigURI) {
return defaultFSURI.getScheme().equals(S3A)
|| (StringUtils.isNotEmpty(zepConfigURI.getScheme())
&& zepConfigURI.getScheme().equals(S3A));
}
```
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
With regards,
Apache Git Services
