jongyoul commented on a change in pull request #3335: [MINOR] Refactor CronJob class URL: https://github.com/apache/zeppelin/pull/3335#discussion_r268381939
########## File path: zeppelin-zengine/src/main/java/org/apache/zeppelin/notebook/Notebook.java ########## @@ -64,11 +65,12 @@ import org.slf4j.Logger; import org.slf4j.LoggerFactory; +import com.google.common.collect.Sets; Review comment: You’re right. Someday we need to adopt same style at a time. And I’m worried about that code style issue always become low priority because it affected a lot but there’s no new feature. It’s a bit hard to make consensus for that reason. :-) ---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
