felixcheung commented on a change in pull request #3337: [ZEPPELIN-4078]
Ipython queue performance
URL: https://github.com/apache/zeppelin/pull/3337#discussion_r267638063
##########
File path: python/src/main/resources/grpc/python/ipython_server.py
##########
@@ -52,24 +52,19 @@ def execute(self, request, context):
print("execute code:\n")
print(request.code.encode('utf-8'))
sys.stdout.flush()
- stdout_queue = queue.Queue(maxsize = 10)
- stderr_queue = queue.Queue(maxsize = 10)
- image_queue = queue.Queue(maxsize = 5)
-
+ stream_reply_queue = queue.Queue(maxsize = 20)
Review comment:
should maxsize be a bit more?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
With regards,
Apache Git Services
