Savalek commented on a change in pull request #3281: [ZEPPELIN-3943] - Add
button "stop notebook execution"
URL: https://github.com/apache/zeppelin/pull/3281#discussion_r247500846
##########
File path: zeppelin-web/src/app/notebook/notebook-actionBar.html
##########
@@ -31,10 +31,20 @@ <h3>
<button type="button"
class="btn btn-default btn-xs"
ng-click="runAllParagraphs(note.id)"
- ng-class="{'disabled':isNoteRunning()}"
+ ng-if=!isNoteRunning()
tooltip-placement="bottom" uib-tooltip="Run all paragraphs"
ng-disabled="revisionView">
<i class="icon-control-play"></i>
+ </button>
+ <button type="button"
+ class="btn btn-default btn-xs"
+ ng-click=stopNoteExecution(note.id)
+ style="color: red"
+ ng-if=isNoteRunning()
+ tooltip-placement="bottom"
+ uib-tooltip="Stop execution"
+ ng-disabled="revisionView">
+ <i class="icon-control-pause"></i>
Review comment:
simple-line-icons.css not contains 'stop' button. Therefore, I used
'icon-control-pause'.
In paragraph-control.html 'icon-control-pause' is also used to stop a
paragraph.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
With regards,
Apache Git Services
