liuxunorg commented on a change in pull request #3271: [ZEPPELIN-3919]
Paragraph config default value can be customized
URL: https://github.com/apache/zeppelin/pull/3271#discussion_r243930611
##########
File path:
zeppelin-zengine/src/main/java/org/apache/zeppelin/notebook/Note.java
##########
@@ -365,6 +369,13 @@ public void fireParagraphUpdateEvent(Paragraph p) throws
IOException {
*/
public Paragraph insertNewParagraph(int index, AuthenticationInfo
authenticationInfo) {
Paragraph paragraph = new Paragraph(this, paragraphJobListener);
+ if (null != interpreterSettingManager) {
+ // Set the default parameter configuration for the paragraph
+ // based on `interpreter-setting.json` config
+ Map<String, Object> config =
+ interpreterSettingManager.getConfigSetting(defaultInterpreterGroup);
+ paragraph.setConfig(config);
+ }
Review comment:
This is very important because:
When you create a new paragraph, you can directly display the custom
configuration, for example, directly display the title bar, otherwise you must
run this paragraph to display the title bar.
For example: create a new submarine interpreter note, the paragraph can
directly display the title bar to facilitate the user to enter the algorithm
name.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
With regards,
Apache Git Services
