Thanks, Jeff and Felix, I simply thought it would be better to construct a more clear view for devs. But, as you mentioned, it could scatter our concentrations. Let's try to do efforts to clean up our code and test scenarios inside one repository.
Thank you guys. On Fri, Dec 14, 2018 at 12:03 PM Jeff Zhang <zjf...@gmail.com> wrote: > Agree with Felix, this is what I also concern in my last email. @Jongyoul > Lee <jongy...@gmail.com> Could you explain more about how separate repo > help here ? Thanks > > > Felix Cheung <felixcheun...@hotmail.com> 于2018年12月14日周五 上午11:00写道： > >> In my opinion, definitely a clean interface will be very useful and >> having a better way to test is good. >> >> But sounds to me like these should be possible without a code repo >> separation? >> >> The downside of separate repo (I assume still under ASF) is the spreading >> the attention of committers and contributors. >> >> >> >> ________________________________ >> From: Jongyoul Lee <jongy...@gmail.com> >> Sent: Tuesday, December 11, 2018 10:33 PM >> To: dev >> Subject: Re: [DISCUSS] Make interpreters' repository >> >> And for testing Z as well, we don't have to build Spark Interpreter again >> for integration tests. and even, we don't have to build zeppelin server >> and >> web for integration test for spark. We just use components built. I >> believe >> it makes our CI as well faster. >> >> On Wed, Dec 12, 2018 at 3:29 PM Jongyoul Lee <jongy...@gmail.com> wrote: >> >> > Yes, right. BTW, I think we need to make dependencies clearly between >> > zeppelin-server and interpreters, and even among interpreters. Some >> > versions properties are used in zeppelin-server and interpreters, but no >> > one has any clear view for them. So I thought it would be a change when >> we >> > divide repositories. The second one is about building and compiling. We >> > don't have to build Zeppelin fully when building some components. We >> also >> > can do it with custom build options including '-pl !...'. I don't think >> > it's good and there's no reason to keep this kind of inconvenience. >> What do >> > you think? >> > >> > Regards, >> > JL >> > >> > On Wed, Dec 12, 2018 at 3:08 PM Jeff Zhang <zjf...@gmail.com> wrote: >> > >> >> Hi Jongyoul, >> >> >> >> Thanks for bring this up. I don't understand how different repo will >> help >> >> here, but I thought about moving interpreters out of zeppelin for a >> long >> >> time, but don't have bandwidth for it. The release cycle of zeppelin >> core >> >> component (zeppelin-zengine, zeppelin-server) should not block the >> release >> >> of interpreter component (unless they depends on some features of >> >> zeppelin-zengine, zeppelin-server). >> >> >> >> >> >> Jongyoul Lee <jongy...@gmail.com> 于2018年12月12日周三 上午10:38写道： >> >> >> >> > Hi, dev and committers, >> >> > >> >> > Currently, I'm seeing the repositories of another apache projects. >> They >> >> > have some several repositories with different purposes. I'd like to >> >> suggest >> >> > you that we divide repositories between zeppelin-server and others. >> >> > >> >> > This will help you develop zeppelin-server without interfering from >> >> other >> >> > components and its dependencies. Even, in the case of interpreters, >> It >> >> will >> >> > provide more independent environments for developing interpreters >> >> > themselves. Currently, we had a lot of dependencies and various >> versions >> >> > for each interpreter. >> >> > >> >> > WDYT? >> >> > >> >> > Regards, >> >> > JL >> >> > >> >> > -- >> >> > 이종열, Jongyoul Lee, 李宗烈 >> >> > http://madeng.net >> >> > >> >> >> >> >> >> -- >> >> Best Regards >> >> >> >> Jeff Zhang >> >> >> > >> > >> > -- >> > 이종열, Jongyoul Lee, 李宗烈 >> > http://madeng.net >> > >> >> >> -- >> 이종열, Jongyoul Lee, 李宗烈 >> http://madeng.net >> > > > -- > Best Regards > > Jeff Zhang > -- 이종열, Jongyoul Lee, 李宗烈 http://madeng.net
