GitHub user egorklimov reopened a pull request:

    https://github.com/apache/zeppelin/pull/3078

    [ZEPPELIN-3628] HTML anchor links on paragraph don't work in Google Chrome

    ### What is this PR for?
    Links like [1] work well in Firefox, but don't work in Chrome.
    1. http://zeppelin/#/notebook/NOTEID?paragraph=PARAGRAPHID
    
    ### What type of PR is it?
    Improvement
    
    ### What is the Jira issue?
    issue on Jira https://issues.apache.org/jira/browse/ZEPPELIN-3628
    
    ### How should this be tested?
    * Manual checking (see screenshot below)
    
    ### Screenshots (if appropriate)
    * #### Before
    Chrome (v67.0.3396.99):
    
    
![chrome](https://user-images.githubusercontent.com/6136993/42819776-31f951e6-89dd-11e8-9618-710f61ea550f.gif)
    Firefox (v61.0.1):
    
    
![firefox](https://user-images.githubusercontent.com/6136993/42819794-39c5562c-89dd-11e8-8059-4e8f85855471.gif)
    * #### After
    Chrome (v67.0.3396.99)
    
    
![fixed](https://user-images.githubusercontent.com/6136993/42819862-63095cd6-89dd-11e8-80a0-843e613ca867.gif)
    
    ### Questions:
    * Does the licenses files need update? 
    Yes, JQuery.scrollTo changed from 1.4.14 to 2.1.2 
    * Is there breaking changes for older versions? No
    * Does this needs documentation? No


You can merge this pull request into a Git repository by running:

    $ git pull https://github.com/TinkoffCreditSystems/zeppelin ZEPPELIN-3628

Alternatively you can review and apply these changes as the patch at:

    https://github.com/apache/zeppelin/pull/3078.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

    This closes #3078
    
----
commit 87ac4ac35c41ec09d092bf28059aa01730157002
Author: egorklimov <klim.electronicmail@...>
Date:   2018-07-17T12:03:45Z

    jQuery ScrollTo updated

commit e2ead1035c67c374e26bc7da92973908e8605b8a
Author: egorklimov <klim.electronicmail@...>
Date:   2018-07-17T12:20:42Z

    jQuery ScrollTo license updated

commit 8b521f80e21e162a9f74d0958b17002d9d0ab4af
Author: egorklimov <klim.electronicmail@...>
Date:   2018-07-17T14:57:57Z

    License github link fixed

commit 3757129dd0515b1c1db9ac42dce1c0dc142af99d
Author: egorklimov <klim.electronicmail@...>
Date:   2018-07-20T11:23:34Z

    Cursor in paragraph text fixed

----


---

Reply via email to