Github user shahsank3t commented on the issue:

    https://github.com/apache/zeppelin/pull/3019
  
    @zjffdu Apologies missed out the earlier notification. 
    
    > I didn't try this PR, but I didn't see backend pass 
spark.ui.allowFramingFrom to frontend, so how does frontend know whether it 
should show spark ui inline or in another windows of the old method ?
    
    Yes, you are right. Frontend is not checking the property 
`spark.ui.allowFramingFrom` and always explicitly showing spark ui 
inline(within a modal).
    If we want to provide the support to fallback, we can check the specified 
property for any value and show ui inline and if no value is set, show in 
another windows. Sounds good?


---

Reply via email to