[GitHub] zeppelin pull request #3027: [ZEPPELIN-2605] Import notebook has 1MB size li...

[sanjaydasgupta]

GitHub user sanjaydasgupta opened a pull request:

    https://github.com/apache/zeppelin/pull/3027

    [ZEPPELIN-2605] Import notebook has 1MB size limit but bigger notebooks can 
be saved without error or warning

    ### What is this PR for?
    Notebooks of any size can be exported and saved, but the import facility 
only accepts notebooks up to 1Mb in size. Allowing notebooks bigger than 1Mb to 
be saved silently (without any warning or error notification) is therefore a 
dangerous trap for users.
    
    It has been argued that notebooks bigger than 1Mb are rare and unusual, but 
a saved notebook also contains the displayed output - and can contain large 
volumes of tabular data, and even images from matplotlib output. Large 
notebooks can be common when zeppelin is used for presentation of visual 
analysis.
    
    This PR adds a popup dialog which is displayed when the user attempts to 
export a notebook that has a size exceeding 1Mb. A screenshot of the popup is 
shown below.
    
    
![popup-dialog](https://user-images.githubusercontent.com/477015/41522941-cb2c5c7c-72f5-11e8-83e6-b3f6f29ee834.png)
    
    ### What type of PR is it?
    [Bug Fix]
    
    ### Todos
    
    ### What is the Jira issue?
    https://issues.apache.org/jira/browse/ZEPPELIN-2605
    
    ### How should this be tested?
    CI pass
    Manual testing. A notebook that is small when outputs are cleared, but 
becomes bigger than the limit when all cells are run is included 
(big-output-tester.json).
    
    
[big-output-tester.json.zip](https://github.com/apache/zeppelin/files/2110281/big-output-tester.json.zip)
    
    ### Screenshots (if appropriate)
    See above.
    
    ### Questions:
    * Does the licenses files need update? No
    * Is there breaking changes for older versions? No
    * Does this needs documentation? No


You can merge this pull request into a Git repository by running:

    $ git pull https://github.com/sanjaydasgupta/zeppelin 
z2605-import-notebook-has-1mb-limit

Alternatively you can review and apply these changes as the patch at:

    https://github.com/apache/zeppelin/pull/3027.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

    This closes #3027
    
----
commit 943eb5df21a5563ccc588164d0799724e7dd3260
Author: Sanjay Dasgupta <sanjay.dasgupta@...>
Date:   2018-06-17T17:17:38Z

    z2605-import-notebook-has-1mb-limit: Initial content

----


---