BTW, please* add unit test for any new PR* unless it is very trivial change and other committer agree it is OK without unit test. If you find it is difficult to add unit test. There will be several reasons according my experience.
1. It is due to the architecture and evolution of zeppelin, as more and more components and features added to zeppelin, many things may be coupled together which make it difficult to add unit test. In this case, please comment in your PR why it is difficult to add unit test, and what is your plan for that. Code refactoring in some component of zeppelin or unit test. 2. It is due to your PR that introduce too much complexity or didn't do it in a elegant approach. In this case, please rethink your PR to improve it. Jeff Zhang <[email protected]>于2018年6月15日周五 上午8:59写道： > Hi Folks, > > The zeppelin travis become unstable again recently. I know it is really > annoying and frustrated, so I create a PR to disable these flaky tests. > There still some flaky test, but happens in low frequency. According my > experience, if you still have travis build failure after this PR, you can > try to rerun the travis build to get travis build pass. Just rerun the > failed one, don't run the whole travis build matrix and also please clear > travis cache first. If there's no objection, I would commit this PR. And > after that, please keep travis build passed before you commit any new > changes. Thanks. > > https://github.com/apache/zeppelin/pull/3020 > >
