GitHub user cvaliente opened a pull request:

    https://github.com/apache/zeppelin/pull/2945

    [ZEPPELIN-3430] fix logic of loading githubnotebookrepo

    ### What is this PR for?
    loadNotebookRepo(String notebookRepoClassName) does not actually load 
notebookRepoClassName but instead it loads the first NotebookRepo class that it 
finds on the plugins classpath. In case of NotebookRepos that depend/extend 
other NotebookRepos, this results in the wrong class being loaded.
    
    
    ### What type of PR is it?
    [Bug Fix]
    
    ### What is the Jira issue?
    * https://issues.apache.org/jira/browse/ZEPPELIN-3430
    
    ### How should this be tested?
    * set up notebook that uses githubrepo and check if the class actually gets 
initialized (look for debug log entry)
    


You can merge this pull request into a Git repository by running:

    $ git pull https://github.com/cvaliente/zeppelin ZEPPELIN-3430

Alternatively you can review and apply these changes as the patch at:

    https://github.com/apache/zeppelin/pull/2945.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

    This closes #2945
    
----
commit 9a2afca254748be8b9b357dcaadef5aae179ae9e
Author: Clemens Valiente <clemens.valiente@...>
Date:   2018-04-25T14:00:41Z

    fix logic of loading githubnotebookrepo

----


---

Reply via email to