Clemens Valiente created ZEPPELIN-3430:
------------------------------------------
Summary: PluginManager loadNoteBook logic is broken
Key: ZEPPELIN-3430
URL: https://issues.apache.org/jira/browse/ZEPPELIN-3430
Project: Zeppelin
Issue Type: Bug
Reporter: Clemens Valiente
[https://github.com/apache/zeppelin/blob/5f88452d63f9b6d7ad00328b1c5a0619e47cbc3c/zeppelin-zengine/src/main/java/org/apache/zeppelin/plugin/PluginManager.java#L87]
loadNotebookRepo(String notebookRepoClassName) does not actually load
notebookRepoClassName but instead it loads the first NotebookRepo class that it
finds on the plugins classpath. In case of NotebookRepos that depend/extend
other NotebookRepos, this results in the wrong class being loaded.
{code}
INFO [2018-04-25 13:12:06,947] ({main} PluginManager.java[loadNotebookRepo]:53)
- Loading NotebookRepo Plugin:
org.apache.zeppelin.notebook.repo.GitHubNotebookRepo
DEBUG [2018-04-25 13:12:06,947] ({main}
PluginManager.java[loadNotebookRepo]:76) - Add file
/root/zeppelin/zeppelin-0.9.0-SNAPSHOT/plugins/NotebookRepo/GitHubNotebookRepo/jsch-0.1.53.jar
to classpath of plugin org.apache.zeppelin.notebook.repo.GitHubNotebookRepo
DEBUG [2018-04-25 13:12:06,947] ({main}
PluginManager.java[loadNotebookRepo]:76) - Add file
/root/zeppelin/zeppelin-0.9.0-SNAPSHOT/plugins/NotebookRepo/GitHubNotebookRepo/notebookrepo-git-0.9.0-SNAPSHOT.jar
to classpath of plugin org.apache.zeppelin.notebook.repo.GitHubNotebookRepo
DEBUG [2018-04-25 13:12:06,948] ({main}
PluginManager.java[loadNotebookRepo]:76) - Add file
/root/zeppelin/zeppelin-0.9.0-SNAPSHOT/plugins/NotebookRepo/GitHubNotebookRepo/commons-vfs2-2.2.jar
to classpath of plugin org.apache.zeppelin.notebook.repo.GitHubNotebookRepo
DEBUG [2018-04-25 13:12:06,948] ({main}
PluginManager.java[loadNotebookRepo]:76) - Add file
/root/zeppelin/zeppelin-0.9.0-SNAPSHOT/plugins/NotebookRepo/GitHubNotebookRepo/notebookrepo-github-0.9.0-SNAPSHOT.jar
to classpath of plugin org.apache.zeppelin.notebook.repo.GitHubNotebookRepo
DEBUG [2018-04-25 13:12:06,948] ({main}
PluginManager.java[loadNotebookRepo]:76) - Add file
/root/zeppelin/zeppelin-0.9.0-SNAPSHOT/plugins/NotebookRepo/GitHubNotebookRepo/commons-codec-1.5.jar
to classpath of plugin org.apache.zeppelin.notebook.repo.GitHubNotebookRepo
DEBUG [2018-04-25 13:12:06,948] ({main}
PluginManager.java[loadNotebookRepo]:76) - Add file
/root/zeppelin/zeppelin-0.9.0-SNAPSHOT/plugins/NotebookRepo/GitHubNotebookRepo/httpclient-4.5.1.jar
to classpath of plugin org.apache.zeppelin.notebook.repo.GitHubNotebookRepo
DEBUG [2018-04-25 13:12:06,948] ({main}
PluginManager.java[loadNotebookRepo]:76) - Add file
/root/zeppelin/zeppelin-0.9.0-SNAPSHOT/plugins/NotebookRepo/GitHubNotebookRepo/commons-logging-1.1.1.jar
to classpath of plugin org.apache.zeppelin.notebook.repo.GitHubNotebookRepo
DEBUG [2018-04-25 13:12:06,949] ({main}
PluginManager.java[loadNotebookRepo]:76) - Add file
/root/zeppelin/zeppelin-0.9.0-SNAPSHOT/plugins/NotebookRepo/GitHubNotebookRepo/notebookrepo-vfs-0.9.0-SNAPSHOT.jar
to classpath of plugin org.apache.zeppelin.notebook.repo.GitHubNotebookRepo
DEBUG [2018-04-25 13:12:06,949] ({main}
PluginManager.java[loadNotebookRepo]:76) - Add file
/root/zeppelin/zeppelin-0.9.0-SNAPSHOT/plugins/NotebookRepo/GitHubNotebookRepo/JavaEWAH-0.7.9.jar
to classpath of plugin org.apache.zeppelin.notebook.repo.GitHubNotebookRepo
DEBUG [2018-04-25 13:12:06,949] ({main}
PluginManager.java[loadNotebookRepo]:76) - Add file
/root/zeppelin/zeppelin-0.9.0-SNAPSHOT/plugins/NotebookRepo/GitHubNotebookRepo/slf4j-api-1.7.10.jar
to classpath of plugin org.apache.zeppelin.notebook.repo.GitHubNotebookRepo
DEBUG [2018-04-25 13:12:06,949] ({main}
PluginManager.java[loadNotebookRepo]:76) - Add file
/root/zeppelin/zeppelin-0.9.0-SNAPSHOT/plugins/NotebookRepo/GitHubNotebookRepo/org.eclipse.jgit-4.5.4.201711221230-r.jar
to classpath of plugin org.apache.zeppelin.notebook.repo.GitHubNotebookRepo
DEBUG [2018-04-25 13:12:06,949] ({main}
PluginManager.java[loadNotebookRepo]:76) - Add file
/root/zeppelin/zeppelin-0.9.0-SNAPSHOT/plugins/NotebookRepo/GitHubNotebookRepo/httpcore-4.4.1.jar
to classpath of plugin org.apache.zeppelin.notebook.repo.GitHubNotebookRepo
{code}
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
