GitHub user yu74n opened a pull request:

    https://github.com/apache/zeppelin/pull/2695

    [ZEPPELIN-3089] Create user folders under Trash folder

    ### What is this PR for?
    In the situation where multi users a create notebook, "Empty Trash" button 
next to "Trash" folder on Top page is not working because "Empty Trash" button 
tries to delete all notebooks in Trash folder. which includes notebook no owner 
and no writer permission.
    
    For resolving this issue, create a user folder under Trash folder, and 
"Empty Trash" button deletes all notebooks in a user folder, while "Restore" 
button restore all notebooks in a user folder.
    
    ### What type of PR is it?
    Bug Fix
    
    ### What is the Jira issue?
    * Open an issue on Jira https://issues.apache.org/jira/browse/ZEPPELIN-3089
    
    ### How should this be tested?
    1. Login as user 'A' and create a notebook 'A'
    2. Move notebook 'A' to Trash
    3. Login as user 'B' and create a notebook 'B'
    4. Move notebook 'B' to Trash
    5. Click 'Empty Trash' button next to 'Trash' folder
    
    ### Screenshots (if appropriate)
    <img width="265" alt="screen_shot_2017-12-05_at_00_59_05" 
src="https://user-images.githubusercontent.com/4197465/33562137-ccc3e358-d957-11e7-980e-253efaa5cd62.png";>
    
    ### Questions:
    * Does the licenses files need update? No
    * Is there breaking changes for older versions? No
    * Does this needs documentation? No


You can merge this pull request into a Git repository by running:

    $ git pull https://github.com/yu74n/zeppelin trash-box-per-user

Alternatively you can review and apply these changes as the patch at:

    https://github.com/apache/zeppelin/pull/2695.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

    This closes #2695
    
----
commit 30bd15231d5cda7cfeb729dc21b13a9a47d1d99a
Author: Yuta Hongo <yut...@gmail.com>
Date:   2017-12-04T11:40:49Z

    Delete all notes under the user folder on executing Empty Trash

commit af678acd9469ffa03061f0c476b2a7804477c38a
Author: Yuta Hongo <yut...@gmail.com>
Date:   2017-12-04T15:37:54Z

    Resolve line length error

----


---

Reply via email to