Github user sadhen commented on the issue:

    https://github.com/apache/zeppelin/pull/2539
  
    @zjffdu 
    
    Your solution didn't solve the problem in the quoted:
    
    `The critical part is that files under conf/ such as shiro.ini is part of 
the docker image and should be immutable.`
    
    Imaging the following use case, I have a base docker image, and two other 
end-point docker images. The base docker image consists of jars and a default 
configuration. And the end-point docker images just config the base image, that 
means for example image0 use CAS auth in `shiro.ini` and image1 use LDAP in 
`shiro.ini`. The immutable part of a deployment identifies a docker image. That 
is the charming part of docker. We should not modify the conf files in a 
mounted volume. If you keep this files in a mounted volume,  you will never 
correctly start up zeppelin with ill configurations.
    
    This is my understanding of dockerization. If you don't agree with me, 
please downvote and I will not waste my time completing this PR.
    
    -----
    
    TODOs:
    1. provide an environment variable to tell Zeppelin where is the notebook 
dir. The variable should be prior to configs in `zeppelin-site.xml` (regardless 
of this pr, this would be nice feature for dockerization)
    2. add some logic in `bin/*sh` for compat.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

Reply via email to