GitHub user imnotkind opened a pull request:
https://github.com/apache/zeppelin/pull/2532
[ZEPPELIN-2850]
###What is this PR for?
in save-as.service.js, if we use URI Data scheme, we could only contain 2MB
data in chrome. using the createObjectURL and File API's blob feature, i
managed to upgrade the capacity to about 900MB. plus this update is better in
debugging too. if we exceed the 2MB limit in URI data scheme, the download just
failed with no accurate console log originally, so it was kinda hard to know
why this happens. But using this technique, if it exceeds the 900MB limit, the
console log points directly about what the problem is. like this : Uncaught
RangeError: Failed to construct 'Blob': Array length exceeds supported limit.
https://github.com/apache/zeppelin/blob/master/zeppelin-web/src/app/notebook/save-as/save-as.service.js
###What type of PR is it?
Improvement
###Todos
nothing more i guess
###What is the Jira issue?
https://issues.apache.org/jira/browse/ZEPPELIN-2850
###How should this be tested?
open zeppelin using chrome. make a table by select, then download it by csv
or tsv. the table should be BIG, like really big, (but not that big for
companies, which is my case) to test. in the original version if the whole data
exceeds 2MB, you could see that the download fails. but using my script, it
doesn't fail until it reaches about 900MB~1GB, which is a tremendous
improvement.
###Screenshots (if appropriate)
i'll post it later if you really need it. but i'm pretty sure you guys know
what i'm talking about :)
###Questions:
Does the licenses files need update? no (i guess)
Is there breaking changes for older versions? no
Does this needs documentation? maybe?
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/imnotkind/zeppelin master
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/zeppelin/pull/2532.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #2532
----
commit e9ad52e1f07e470b1ba086a21b554c0e7904b61e
Author: imnotkind <billy...@daum.net>
Date: 2017-08-15T05:09:19Z
Update save-as.service.js
if we use URI Data scheme, we could only contain 2MB data in chrome. using
the createObjectURL and File API's blob feature, i managed to upgrade the
capacity to about 900MB.
commit db778b145b779ce4e0bf82ad1b0b67f749c905bf
Author: imnotkind <billy...@daum.net>
Date: 2017-08-15T06:48:17Z
Merge pull request #1 from imnotkind/imnotkind-patch-1
[ZEPPELIN-2850]
----
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---
