GitHub user sohaibiftikhar opened a pull request:

    https://github.com/apache/zeppelin/pull/2500

    [ZEPPELIN-2804] Fix shiro_authentication documentation

    The github preview is fine but the html on 
https://zeppelin.apache.org/docs/0.8.0-SNAPSHOT/security/shiroauthentication.html#ldap
 is not displaying the code fragment correctly.
    
    ### What is this PR for?
    Fixes the documentation orientation for shiro LDAPRealm
    
    ### What type of PR is it?
    [Documentation]
    
    ### Todos
    
    
    ### What is the Jira issue?
    https://issues.apache.org/jira/browse/ZEPPELIN-2804
    
    ### How should this be tested?
    Build the documentation and verify that the problem as stated in image is 
resolved.
    
    ### Screenshots (if appropriate)
    <img width="856" alt="screen shot 2017-07-21 at 10 08 04 am" 
src="https://user-images.githubusercontent.com/5103613/28454775-c91fbe1e-6dfc-11e7-9601-6279be44f124.png";>
    
    
    ### Questions:
    * Does the licenses files need update? N
    * Is there breaking changes for older versions? N
    * Does this needs documentation? N


You can merge this pull request into a Git repository by running:

    $ git pull https://github.com/sohaibiftikhar/zeppelin patch-1

Alternatively you can review and apply these changes as the patch at:

    https://github.com/apache/zeppelin/pull/2500.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

    This closes #2500
    
----
commit 94e184333eebf53e32749a89b637f1ef859d7fba
Author: Sohaib Iftikhar <sohaib1...@gmail.com>
Date:   2017-07-21T08:07:25Z

    Fixed documentation for shiro LDAPRealm
    
    The github preview is fine but the html on 
https://zeppelin.apache.org/docs/0.8.0-SNAPSHOT/security/shiroauthentication.html#ldap
 is not displaying the code fragment correctly.

----


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

Reply via email to