Hoon Park created ZEPPELIN-2734:
-----------------------------------
Summary: [FRONT-BUILD] Remove lodash dependency
Key: ZEPPELIN-2734
URL: https://issues.apache.org/jira/browse/ZEPPELIN-2734
Project: Zeppelin
Issue Type: Sub-task
Components: build, front-end
Reporter: Hoon Park
Since we are using es6+, we can remove lodash dependency. It will reduce the
size of the bundle.
{code}
➜ zeppelin-web git:(ZEPPELIN-2725/use-npm-packages-instead-of-bower) ✗ git aa
gOn branch ZEPPELIN-2725/use-npm-packages-instead-of-bower
Changes to be committed:
(use "git reset HEAD <file>..." to unstage)
modified: zeppelin-web/.eslintrc
➜ zeppelin-web git:(ZEPPELIN-2725/use-npm-packages-instead-of-bower) ✗ git
commit --amend
[ZEPPELIN-2725/use-npm-packages-instead-of-bower 79f504bf] fix: Remove unused
global var
Date: Thu Jul 6 15:27:42 2017 +0900
1 file changed, 3 deletions(-)
➜ zeppelin-web git:(ZEPPELIN-2725/use-npm-packages-instead-of-bower) cd src
➜ src git:(ZEPPELIN-2725/use-npm-packages-instead-of-bower) ag "_\."
app/app.controller.js
50: if (!_.isEmpty(note)) {
app/credential/credential.controller.js
32: $scope.credentialInfo = _.map(data.body.userCredentials, function
(value, prop) {
53: if ($scope.entity && _.isEmpty($scope.entity.trim()) &&
54: $scope.username && _.isEmpty($scope.username.trim())) {
146: let index = _.findIndex($scope.credentialInfo, {'entity': entity})
173: let index = _.findIndex($scope.credentialInfo, {'entity':
entity})
app/credential/credential.html
88: <div ng-show="_.isEmpty(credentialInfo) || valueform.$hidden"
92: <div class="col-md-12" ng-show="!_.isEmpty(credentialInfo) ||
valueform.$visible">
app/helium/helium.controller.js
110: for (let idx in _.keys(HeliumType)) {
111: allTypesOfPkg[_.keys(HeliumType)[idx]] = pkgsArr[idx]
157: let filteredPkgSearchResults = _.filter($scope.defaultPackages[name],
function (p) {
163: filteredPkgSearchResults = _.filter($scope.pkgSearchResults[name],
function (p) {
310: _.map(pkgSearchResult, function (pkg) {
311: result.push(_.find(pkg, {type: targetPkgType}))
313: return _.compact(result).length
app/interpreter/interpreter.controller.js
179: let index = _.findIndex($scope.interpreterSettings, {'id': settingId})
188: let index = _.findIndex($scope.interpreterSettings, {'id': settingId})
213: let index = _.findIndex($scope.interpreterSettings, {'id': settingId})
238: let index = _.findIndex($scope.interpreterSettings, {'id': settingId})
257: let index = _.findIndex($scope.interpreterSettings, {'id': settingId})
282: let index = _.findIndex($scope.interpreterSettings, {'id': settingId})
318: let index = _.findIndex($scope.interpreterSettings, {'id': settingId})
335: let index = _.findIndex($scope.interpreterSettings, {'id':
settingId})
398: let index = _.findIndex($scope.interpreterSettings, {'id': settingId})
414: let index = _.findIndex($scope.interpreterSettings, {'id':
settingId})
425: let el = _.pluck(_.filter($scope.availableInterpreters, {'name':
$scope.newInterpreterSetting.group}),
449: let index = _.findIndex($scope.interpreterSettings, {'id':
settingId})
483: if (_.findIndex($scope.interpreterSettings, {'name':
$scope.newInterpreterSetting.name}) >= 0) {
552: let index = _.findIndex($scope.interpreterSettings, {'id': settingId})
559: $scope.newInterpreterSetting.dependencies =
_.reject($scope.newInterpreterSetting.dependencies,
564: let index = _.findIndex($scope.interpreterSettings, {'id': settingId})
565: $scope.interpreterSettings[index].dependencies =
_.reject($scope.interpreterSettings[index].dependencies,
585: let index = _.findIndex($scope.interpreterSettings, {'id': settingId})
622: let index = _.findIndex($scope.interpreterSettings, {'id': settingId})
693: let index = _.findIndex($scope.repositories, {'id': repoId})
app/jobmanager/jobmanager.controller.js
111: let index = _.findIndex($scope.activeInterpreters, {value: filterValue})
154: $scope.jobInfomationsIndexs = $scope.jobInfomations ?
_.indexBy($scope.jobInfomations, 'noteId') : {}
162: let interpreterLists = _.uniq(_.pluck($scope.jobInfomations,
'interpreter'), false)
187: let removeIndex = _.findIndex(indexStore, changedItem.noteId)
192: removeIndex = _.findIndex(jobInfomations, {'noteId':
changedItem.noteId})
app/jobmanager/jobmanager.filter.js
31: filterItems = _.where(filterItems, {interpreter:
filterValueInterpreter})
app/interpreter/interpreter.html
390: <div ng-show="_.isEmpty(setting.properties) &&
_.isEmpty(setting.dependencies) && !valueform.$visible" class="col-md-12
gray40-message">
393: <div class="col-md-12" ng-show="!_.isEmpty(setting.properties) ||
valueform.$visible">
434: <div class="col-md-12" ng-show="!_.isEmpty(setting.dependencies) ||
valueform.$visible">
app/jobmanager/jobs/job.controller.js
30: let statusList = _.pluck($scope.notebookJob.paragraphs, 'status')
31: let runningJob = _.countBy(statusList, function (status) {
app/notebook/notebook.controller.js
239: let index = _.findIndex($scope.noteRevisions, {'id':
$routeParams.revisionId})
302: _.forEach($scope.note.paragraphs, function (par) {
485: _.each($scope.note.paragraphs, function (para, idx) {
603: _.forEach($scope.note.paragraphs, function (n, key) {
747: let index = _.findIndex($scope.interpreterSettings, {'id':
interpreter.id})
863: _.indexOf($scope.permissions.owners, $rootScope.ticket.principal) <
0) {
app/notebook/paragraph/paragraph.controller.js
928: _.merge($scope.paragraph.config.editorSetting, setting.editor)
app/notebook/paragraph/result/result.controller.js
341: activeApp = _.get($scope.config, 'helium.activeApp')
345: const appState = _.find($scope.apps, {id: activeApp})
628: _.set(newConfig, 'helium.activeApp', undefined)
799: _.set(newConfig, 'helium.activeApp', appId)
824: _.forEach(paragraph.apps, function (app) {
835: _.forEach($scope.apps, function (currentAppState, idx) {
836: let newAppState = _.find(appStates, {id: currentAppState.id})
845: _.forEach(appStates, function (app, idx) {
885: let app = _.find($scope.apps, {id: data.appId})
889: let paragraphAppState = _.find(paragraph.apps, {id: data.appId})
902: let app = _.find($scope.apps, {id: data.appId})
906: let paragraphAppState = _.find(paragraph.apps, {id: data.appId})
919: let app = _.find($scope.apps, {id: data.appId})
937: let app = _.find($scope.apps, {id: data.appId})
940: let paragraphAppState = _.find(paragraph.apps, {id: data.appId})
967: let app = _.find($scope.apps, {id: data.paragraphId})
1035: let app = _.find($scope.apps, {id: data.paragraphId})
app/notebookRepos/notebookRepos.controller.js
37: let index = _.findIndex(vm.notebookRepos, {'className':
repo.className})
56: let index = _.findIndex(setting.value, {'value': setting.selected})
app/tabledata/networkdata.js
59: let baseCols = _.map(baseColumnNames, function(col) { return col.name })
60: let keys = _.map(entities, function(elem) { return Object.keys(elem.data
|| {}) })
61: keys = _.flatten(keys)
62: keys = _.uniq(keys).filter(function(key) {
65: let columnNames = baseColumnNames.concat(_.map(keys, function(elem, i) {
137: let keys = _.uniq(Object.keys(node.data || {})
app/visualization/builtins/visualization-d3network.js
145: html = html.concat(_.map(entity.data, (v, k) => {
components/noteListDataFactory/noteList.datafactory.js
29: notes.flatList = _.map(notesList, (note) => {
38: _.reduce(notesList, function (root, note) {
60: let dir = _.find(curDir.children,
components/noteAction/noteAction.service.js
139: if (_.has(noteListDataFactory.flatFolderMap, newFolderId)) {
{code}
--
This message was sent by Atlassian JIRA
(v6.4.14#64029)