Github user Leemoonsoo commented on the issue:
https://github.com/apache/zeppelin/pull/1446
I agree on the direction of this PR. But on the implementation I wish we
try keep `class RemoteInterpreter` interpreter independent as much as possible.
This PR adds spark specific code to
`RemoteInterpreter.getEnvFromInterpreterProperty()`.
And we used to have spark specific code in `bin/interpreter.sh`.
In the future, it'll be better if we provide generic facility in both
`bin/interpreter.sh` and `class RemoteInterpreter` and move all spark specific
code into spark interpreter module.
What do you think @zjffdu? This doesn't need to be addressed in this PR but
if you think it's right direction, i wish we at least create a issue for it, so
we can keep track on it.
Other than that, LGTM.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---
