Github user zjffdu commented on the issue:
https://github.com/apache/zeppelin/pull/2443
This PR LGTM. Just one comment on the base class `KerberosInterpreter`. I
think `startKerberosLoginThread` and `shutdownExecutorService` should be called
in `KerberosInterpreter`'s open and close method rather than ask the sub class
to call them. The sub class should only implement 2 abstract classes:
* isKerboseEnabled
* runKerberosLogin
Which means
```
public void open() {
if (isKerboseEnabled()) {
startKerberosLoginThread()
}
}
public void close() {
if (isKerboseEnabled()) {
shutdownExecutorService()
}
}
```
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---
