GitHub user 1ambda reopened a pull request:

    https://github.com/apache/zeppelin/pull/2441

    [ZEPPELIN-2683] fix: should provide horizontal scrollbar for table

    ### What is this PR for?
    
    fixed to use a more broad column width (150+)
    
    - the default is 150
    - if column.length * 10 > 150, use it
    
    additionally, I tried 
[ui-grid-auto-fit-columns](https://www.npmjs.com/package/ui-grid-auto-fit-columns)
 but doesn't work.
    
    ### What type of PR is it?
    [Improvement]
    
    ### Todos
    
    DONE
    
    ### What is the Jira issue?
    
    [ZEPPELIN-2583](https://issues.apache.org/jira/browse/ZEPPELIN-2683)
    
    ### How should this be tested?
    
    Execute these paragraph sequentially
    
    ```scala
    %spark
    
    import org.apache.commons.io.IOUtils
    import java.net.URL
    import java.nio.charset.Charset
    
    // Zeppelin creates and injects sc (SparkContext) and sqlContext 
(HiveContext or SqlContext)
    // So you don't need create them manually
    
    // load bank data
    val bankText = sc.parallelize(
        IOUtils.toString(
            new 
URL("https://s3.amazonaws.com/apache-zeppelin/tutorial/bank/bank.csv";),
            Charset.forName("utf8")).split("\n"))
    
    case class Bank(
        age: Integer, 
        job: String, 
        marital: String, 
        education: String, 
        balance: Integer,
        housing: String,
        loan: String,
        contact: String,
        day: Int,
        month: String,
        duration: Int,
        campaign: String,
        pdays: Int,
        previous: Int,
        poutcome: String,
        y: String
    )
    
    val bank = bankText.map(s => s.split(";")).filter(s => s(0) != 
"\"age\"").map(
        s => Bank(s(0).toInt, 
            s(1).replaceAll("\"", ""),
            s(2).replaceAll("\"", ""),
            s(3).replaceAll("\"", ""),
            s(5).replaceAll("\"", "").toInt,
            s(6).replaceAll("\"", ""),
            s(7).replaceAll("\"", ""),
            s(8).replaceAll("\"", ""),
            s(9).replaceAll("\"", "").toInt,
            s(10).replaceAll("\"", ""),
            s(11).replaceAll("\"", "").toInt,
            s(12).replaceAll("\"", ""),
            s(13).replaceAll("\"", "").toInt,            
            s(14).replaceAll("\"", "").toInt,            
            s(15).replaceAll("\"", ""),
            s(16).replaceAll("\"", "")
        )
    ).toDF()
    
    bank.registerTempTable("bank")
    ```
    
    ```sql
    %sql
    
    select 
        age as age,
        job as job,
        marital as marital_ABCDEFGHIJKLMNOPQRSTUVWXYZ,
        education as education_ABCDEFGHIJKLMNOPQRSTUVWXYZ,
        balance as balance_ABCDEFGHIJKLMNOPQRSTUVWXYZ,
        housing as housing_ABCDEFGHIJKLMNOPQRSTUVWXYZ,
        loan as loan_ABCDEFGHIJKLMNOPQRSTUVWXYZ,
        contact as contact_ABCDEFGHIJKLMNOPQRSTUVWXYZ,
        day as days_ABCDEFGHIJKLMNOPQRSTUVWXYZ,
        month as month_ABCDEFGHIJKLMNOPQRSTUVWXYZ,
        duration as duration_ABCDEFGHIJKLMNOPQRSTUVWXYZ,
        campaign as compaign_ABCDEFGHIJKLMNOPQRSTUVWXYZ,
        pdays as pdays_ABCDEFGHIJKLMNOPQRSTUVWXYZ,
        previous as previous_ABCDEFGHIJKLMNOPQRSTUVWXYZ,
        poutcome as poutcome_ABCDEFGHIJKLMNOPQRSTUVWXYZ,
        y as y_ABCDEFGHIJKLMNOPQRSTUVWXYZ
        
    from bank
    ```
    
    ### Screenshots (if appropriate)
    
    #### Before
    
    
![image](https://user-images.githubusercontent.com/4968473/27570401-cde9ad78-5b38-11e7-9165-c6148c5b2137.png)
    
    #### After
    
    
![2683_after](https://user-images.githubusercontent.com/4968473/27570484-8b9401de-5b39-11e7-9414-75af9a73bc2f.gif)
    
    
    ### Questions:
    * Does the licenses files need update? - NO
    * Is there breaking changes for older versions? - NO
    * Does this needs documentation? - NO


You can merge this pull request into a Git repository by running:

    $ git pull https://github.com/1ambda/zeppelin 
ZEPPELIN-2683/should-provide-horizontal-scroll-for-columns

Alternatively you can review and apply these changes as the patch at:

    https://github.com/apache/zeppelin/pull/2441.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

    This closes #2441
    
----
commit 8081bb5ca6dff048f166353f29c6321b96639e75
Author: 1ambda <1am...@gmail.com>
Date:   2017-06-27T03:52:13Z

    fix: set minWidth for columns

----


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

Reply via email to