GitHub user 1ambda opened a pull request:

    https://github.com/apache/zeppelin/pull/2436

    [ZEPPELIN-2690] fix: should respect helium vis order in result

    ### What is this PR for?
    
    Fixed to respect helium vis order in results.
    
    This PR is written based on https://github.com/apache/zeppelin/pull/2424. 
Will be rebased after 2760 is handled.
    
    ### What type of PR is it?
    [Bug Fix]
    
    ### Todos
    DONE
    
    ### What is the Jira issue?
    
    [ZEPPELIN-2670](https://issues.apache.org/jira/browse/ZEPPELIN-2690)
    
    ### How should this be tested?
    
    1. Set vis order in `#helium`
    2. Open a paragraph containing a table.
    
    ### Screenshots (if appropriate)
    
    #### Before
    
    
![image](https://user-images.githubusercontent.com/4968473/27524943-a0788edc-5a74-11e7-8fbf-8d5d8f6b3644.png)
    
    #### After
    
    
![2690_after](https://user-images.githubusercontent.com/4968473/27525004-0b34ac1a-5a75-11e7-8c9a-6532988297b1.gif)
    
    
    ### Questions:
    * Does the licenses files need update? - NO
    * Is there breaking changes for older versions? - NO
    * Does this needs documentation? - NO


You can merge this pull request into a Git repository by running:

    $ git pull https://github.com/1ambda/zeppelin 
ZEPPELIN-2690/should-respect-helium-vis-order-in-result

Alternatively you can review and apply these changes as the patch at:

    https://github.com/apache/zeppelin/pull/2436.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

    This closes #2436
    
----
commit bdb208ee6fbf56516905c2cbdb8d360937e7a2eb
Author: 1ambda <1am...@gmail.com>
Date:   2017-06-21T06:31:14Z

    style: move getVisualizationPackageOrder func

commit 6b09659825700b3766cdc250862c7745c2e8b780
Author: 1ambda <1am...@gmail.com>
Date:   2017-06-21T06:31:36Z

    style: Rename setVisualizationPackageOrder

commit 7ce0db14bafeb6cb936e6fdf5a0d3c92168024bc
Author: 1ambda <1am...@gmail.com>
Date:   2017-06-21T07:15:14Z

    style: reindent saveBundleOrder

commit bc623a61193a58e1a299f3a2728c822b01d0f6e8
Author: 1ambda <1am...@gmail.com>
Date:   2017-06-21T07:45:16Z

    fix: DON'T build when set orders

commit 579c8c632ef465161f087b7fc72035fe7fe94454
Author: 1ambda <1am...@gmail.com>
Date:   2017-06-21T08:05:38Z

    fix: Fetch bundleOrder after getAllPackages

commit 8d999c29e5684ae94917e02056d867a87720601d
Author: 1ambda <1am...@gmail.com>
Date:   2017-06-21T08:15:57Z

    fix: DON'T call unncessary init()

commit c9f3db72b7a198645adb2bdb37ed3c764e5703da
Author: 1ambda <1am...@gmail.com>
Date:   2017-06-21T10:45:06Z

    fix: DON'T reset when getting display order

commit 5bac94c53e6bdb42a2a2038f7b068a162dedeeca
Author: 1ambda <1am...@gmail.com>
Date:   2017-06-26T04:35:15Z

    fix: Respect helium vis order in result

----


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

Reply via email to