Github user zjffdu commented on the issue:

    https://github.com/apache/zeppelin/pull/2272
  
    @jongyoul Thanks for the review. Copy my comment above. 
    ```
    toJson and fromJson is used in both zeppelin-interpreter and 
zeppelin-zengine. I didn't find a proper place to put the common interface. And 
actually the interface doesn't eliminate the code duplication, the sub classes 
still need to implement toJson as not every classes share the same Gson (some 
class need custom Gson). So I didn't add a common interface. 
    ```


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

Reply via email to