Github user volumeint commented on the issue:

    https://github.com/apache/zeppelin/pull/2373
  
    It turns out that the Pac4JPrincipal provided by buji is returning
    CommonProfile.getId() and not the getUsername() or getDisplayName() values
    for getName().
    
    
https://github.com/bujiio/buji-pac4j/blob/master/src/main/java/io/buji/pac4j/subject/Pac4jPrincipal.java
    
    I believe the intent of the Principal.getName() method is to return a
    human-friendly name, not a computer-friendly identifier.  I created an
    issue on the Buji github project to see if they are open to changing it.
    
    https://github.com/bujiio/buji-pac4j/issues/61
    
    
    On Fri, Jun 9, 2017 at 6:50 AM, Andrea Peruffo <notificati...@github.com>
    wrote:
    
    > *@andreaTP* commented on this pull request.
    > ------------------------------
    >
    > In zeppelin-web/src/components/navbar/navbar.html
    > <https://github.com/apache/zeppelin/pull/2373#discussion_r121099593>:
    >
    > > @@ -86,7 +86,7 @@
    >              <i ng-if="!navbar.connected" class="fa fa-circle 
server-disconnected"
    >                 uib-tooltip="WebSocket Disconnected" 
tooltip-placement="bottom" style="margin-top: 7px; vertical-align: top"></i>
    >              <button ng-if="ticket" class="nav-btn dropdown-toggle" 
type="button" data-toggle="dropdown" style="margin:11px 5px 0 0; padding-left: 
0px;">
    > -              <span class="username">{{ticket.principal}}</span>
    > +              <span class="username">{{ticket.screenUsername}}</span>
    >
    > @volumeint <https://github.com/volumeint> I like your proposal and
    > implemented it, unfortunately it turns out that for example with Keycloak
    > from "getName" I got instead the UUID
    >
    > —
    > You are receiving this because you were mentioned.
    > Reply to this email directly, view it on GitHub
    > <https://github.com/apache/zeppelin/pull/2373#discussion_r121099593>, or 
mute
    > the thread
    > 
<https://github.com/notifications/unsubscribe-auth/Aa_ih9guSoye9v10b1bqHjOCfWJ-ULxeks5sCSORgaJpZM4NpYAh>
    > .
    >



---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

Reply via email to