GitHub user volumeint opened a pull request:

    https://github.com/apache/zeppelin/pull/2313

    ZEPPELIN-2268. Adding png and jpg support for helium module imports.

    ### What is this PR for?
    To allow helium modules to import CSS that contains references to png or 
jpg images.
    
    ### What type of PR is it?
    Improvement
    
    ### Todos
    * [ ] - Task
    
    ### What is the Jira issue?
    * [ZEPPELIN-2268]
    
    ### How should this be tested?
    The volume-leaflet helium module 
[https://github.com/volumeint/helium-volume-leaflet] imports the Leaflet css 
file.  That css file references a couple of png files.  Before this change, the 
helium module would fail to enable, after the change it succeeds.  
    
    ### Screenshots (if appropriate)
    
    ### Questions:
    * Does the licenses files need update? No.
    * Is there breaking changes for older versions?  No.
    * Does this needs documentation? No.


You can merge this pull request into a Git repository by running:

    $ git pull https://github.com/volumeint/zeppelin master

Alternatively you can review and apply these changes as the patch at:

    https://github.com/apache/zeppelin/pull/2313.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

    This closes #2313
    
----
commit 19500d5c7ea92caf477f9fdf6cf07791b6666825
Author: Thomas Grant <tgr...@volumeintegration.com>
Date:   2017-05-03T15:41:01Z

    ZEPPELIN-2268. Adding png and jpg support for helium module imports.

commit c736dbed0b47cf5262e47422863d2950298356a1
Author: Thomas Grant <tgr...@volumeintegration.com>
Date:   2017-05-03T15:45:26Z

    Merge branch 'master' of https://github.com/apache/zeppelin

----


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

Reply via email to